[
https://issues.apache.org/jira/browse/ZOOKEEPER-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764858#action_12764858
]
Patrick Hunt commented on ZOOKEEPER-549:
----------------------------------------
No, the current build has 0 findbugs warnings (and we want to keep it that way)
-- if you use the exclusion list that's in svn.
It may be the case that the exclusion matcher is no longer matching, if you
say, moved some code around. You may need to update
the findbugs exclusion list as part of the patch.
> Refactor Followers and related classes into a Peer->Follower hierarchy in
> preparation for Observers
> ---------------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-549
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-549
> Project: Zookeeper
> Issue Type: Improvement
> Components: quorum, server
> Affects Versions: 3.2.1
> Reporter: Henry Robinson
> Assignee: Henry Robinson
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-549.patch
>
>
> For the Observers patch (ZOOKEEPER-368), a lot of functionality is shared
> between Followers and Observers. To avoid copying code, it makes sense to
> push the common code into a parent Peer class and specialise it for Followers
> and Observers. At the same time, some of the lengthier methods in Follower
> can be broken up to make the code more readable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
