[ https://issues.apache.org/jira/browse/ZOOKEEPER-510?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Henry Robinson updated ZOOKEEPER-510: ------------------------------------- Attachment: ZOOKEEPER-510-incref.patch Here's the patch for the incref issue. Try as I might, I haven't yet got a gc collection to dispose of the exception object and therefore trigger potential segfaults when the zookeeper module raises. So I haven't included any further tests. There are tests already that should exercise the paths prone to error if the behaviour of the gc does become more aggressive in future. Like I said previously, the reference that Patrick provides appears to be authoritative and explicitly describes this situation, so I think it's clearly correct to INCREF the exception objects. > zkpython lumps all exceptions as IOError, needs specialized exceptions for > KeeperException types > ------------------------------------------------------------------------------------------------ > > Key: ZOOKEEPER-510 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-510 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bindings > Affects Versions: 3.2.0 > Reporter: Patrick Hunt > Assignee: Henry Robinson > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-510-incref.patch, ZOOKEEPER-510.patch, > ZOOKEEPER-510.patch, ZOOKEEPER-510.patch, ZOOKEEPER-510.patch > > > The current zkpython bindings always throw "IOError("text")" exceptions, even > for ZK specific exceptions such as NODEEXISTS. This makes it difficult (error > prone) to handle exceptions in python code. You can't easily pickup a > connection loss vs a node exists for example. Of course you could match the > error string, but this seems like a bad idea imo. > We need to add specific exception types to the python binding that map > directly to KeeperException/java types. It would also be useful to include > the information provided by the KeeperException (like path in some cases), > etc... as part of the error thrown to the python code. Would probably be a > good idea to stay as close to java api as possible wrt mapping the errors. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.