[ https://issues.apache.org/jira/browse/ZOOKEEPER-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768458#action_12768458 ]
Patrick Hunt commented on ZOOKEEPER-549: ---------------------------------------- To put a fine point on that - ensure that the refactored code is b/w compatible with the original code. That should be a general goal as well as an item in the patch reviewers checklist. > Refactor Followers and related classes into a Peer->Follower hierarchy in > preparation for Observers > --------------------------------------------------------------------------------------------------- > > Key: ZOOKEEPER-549 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-549 > Project: Zookeeper > Issue Type: Improvement > Components: quorum, server > Affects Versions: 3.2.1 > Reporter: Henry Robinson > Assignee: Henry Robinson > Fix For: 3.3.0 > > Attachments: ZOOKEEPER-549.patch, ZOOKEEPER-549.patch, > ZOOKEEPER-549.patch, ZOOKEEPER-549.patch > > > For the Observers patch (ZOOKEEPER-368), a lot of functionality is shared > between Followers and Observers. To avoid copying code, it makes sense to > push the common code into a parent Peer class and specialise it for Followers > and Observers. At the same time, some of the lengthier methods in Follower > can be broken up to make the code more readable. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.