[ https://issues.apache.org/jira/browse/ZOOKEEPER-472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776572#action_12776572 ]
Patrick Hunt commented on ZOOKEEPER-472: ---------------------------------------- In general we should have tests but I'm fine with the no-test in this case, this is an optimization not a bug fix and I can't think of any test we could add that would benefit, we already have good test coverage on this area. > Making DataNode not instantiate a HashMap when the node is ephmeral > ------------------------------------------------------------------- > > Key: ZOOKEEPER-472 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-472 > Project: Zookeeper > Issue Type: Improvement > Components: server > Affects Versions: 3.1.1, 3.2.0 > Reporter: Erik Holstad > Assignee: Erik Holstad > Priority: Minor > Fix For: 3.3.0 > > Attachments: zookeeper-472.patch, zookeeper-472.patch, > zookeeper-472.patch, zookeeper-472.patch, zookeeper-472.patch, > zookeeper-472.patch > > > Looking at the code, there is an overhead of a HashSet object for that nodes > children, even though the node might be an ephmeral node and cannot have > children. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.