[
https://issues.apache.org/jira/browse/ZOOKEEPER-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12781578#action_12781578
]
Hadoop QA commented on ZOOKEEPER-425:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12425830/buildxmlpatch.patch
against trunk revision 882744.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/74/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/74/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/74/console
This message is automatically generated.
> Add OSGi metadata to zookeeper.jar
> ----------------------------------
>
> Key: ZOOKEEPER-425
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-425
> Project: Zookeeper
> Issue Type: Improvement
> Components: build
> Reporter: David Bosschaert
> Fix For: 3.3.0
>
> Attachments: buildxmlpatch.patch, MANIFEST.MF, zk_patch3.patch
>
>
> After adding OSGi metadata to zookeeper.jar it can be used as both an OSGi
> bundle as well as an ordinary jar file.
> In the CXF/DOSGi project the buildsystem does this using the
> maven-bundle-plugin:
> http://svn.apache.org/repos/asf/cxf/dosgi/trunk/discovery/distributed/zookeeper-wrapper/pom.xml
> The MANIFEST.MF generated by maven-bundle-plugin is attached to this bug,
> this works for the CXF/DOSGi project.
> If your buildsystem isn't using maven, I would advise to use bnd
> (http://www.aqute.biz/Code/Bnd). BND defines its own ant task in which you
> should be able to use more or less the same instructions as were used in
> maven:
> <instructions>
> <Bundle-Name>ZooKeeper bundle</Bundle-Name>
> <Bundle-Description>This bundle contains the ZooKeeper
> library</Bundle-Description>
> <Bundle-SymbolicName>org.apache.hadoop.zookeeper</Bundle-SymbolicName>
> <Bundle-Version>3.1.1</Bundle-Version>
> <Import-Package>*</Import-Package>
> <Export-Package>*;version=3.1.1</Export-Package>
> </instructions>
> Oh and one other thing. Is it really necessary to put the source code in the
> Jar file too? I would put that in a separate source distribution :)
> See also:
> http://mail-archives.apache.org/mod_mbox/hadoop-zookeeper-user/200905.mbox/%[email protected]%3e
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
