[
https://issues.apache.org/jira/browse/ZOOKEEPER-600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789476#action_12789476
]
Hadoop QA commented on ZOOKEEPER-600:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12426565/deallocate-vector.patch
against trunk revision 888216.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/22/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/22/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/22/console
This message is automatically generated.
> TODO pondering about allocation behavior in zkpython may be removed
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-600
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-600
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.2.1
> Reporter: Gustavo Niemeyer
> Assignee: Gustavo Niemeyer
> Priority: Trivial
> Fix For: 3.3.0
>
> Attachments: deallocate-vector.patch
>
>
> I suppose the TODO below is referring to the "path" variable which is passed
> in as an output variable to PyArg_ParseTuple right below. The TODO may be
> removed, since the code is right. Code using PyArg_ParseTuple will borrow
> the reference from the calling code, since there's a stack behind the call to
> the enclosing function (pyzoo_get_children in this case) which won't go away
> until the function returns.
> Index: src/contrib/zkpython/src/c/zookeeper.c
> ===================================================================
> --- src/contrib/zkpython/src/c/zookeeper.c (revision 885582)
> +++ src/contrib/zkpython/src/c/zookeeper.c (working copy)
> @@ -774,8 +774,6 @@
>
> static PyObject *pyzoo_get_children(PyObject *self, PyObject *args)
> {
> - // TO DO: Does Python copy the string or the reference? If it's the former
> - // we should free the String_vector
> int zkhid;
> char *path;
> PyObject *watcherfn = Py_None;
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
