[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12789578#action_12789578
 ] 

Henry Robinson commented on ZOOKEEPER-610:
------------------------------------------

+1 from me, tests don't need to be included as there are no functional changes 
(compiler would pick up any problems). We are a bit inconsistent about when we 
initialise inline in the class, and when we initialise in the constructor, but 
that's not for this patch to fix. 

Will (attempt to) commit shortly. 



> cleanup final fields, esp those used for locking
> ------------------------------------------------
>
>                 Key: ZOOKEEPER-610
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-610
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: java client, server
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>            Priority: Minor
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-610.patch
>
>
> There are a number of places where we have non-final fields that could 
> (should) be declared as final.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to