[ https://issues.apache.org/jira/browse/ZOOKEEPER-612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804054#action_12804054 ]
Hadoop QA commented on ZOOKEEPER-612: ------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12431209/ZOOKEEPER-612.patch against trunk revision 902320. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/52/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/52/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/52/console This message is automatically generated. > Make Zookeeper C client can be compiled by gcc of early version > --------------------------------------------------------------- > > Key: ZOOKEEPER-612 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-612 > Project: Zookeeper > Issue Type: Improvement > Components: c client > Affects Versions: 3.2.1 > Environment: Linux > Reporter: Qian Ye > Assignee: Qian Ye > Fix For: 3.3.0 > > Attachments: patch, patch, ZOOKEEPER-612.patch, ZOOKEEPER-612.patch, > ZOOKEEPER-612.patch, ZOOKEEPER-612.patch > > > The original C Client, Version 3.2.1, cannot be compiled successfully by the > gcc of early version, due some declaration restriction. To compile the source > code on the server with gcc of early version, I made some modification on the > original source. What's more, some extra codes are added to make the client > be compatible with the hosts list format: ip1:port1, ip2:port2... There is > often a space after this kind of comma. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.