[
https://issues.apache.org/jira/browse/ZOOKEEPER-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804791#action_12804791
]
Hadoop QA commented on ZOOKEEPER-456:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12431373/ZOOKEEPER-456.patch
against trunk revision 902694.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/57/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/57/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h7.grid.sp2.yahoo.net/57/console
This message is automatically generated.
> CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion.
> --------------------------------------------------------------
>
> Key: ZOOKEEPER-456
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-456
> Project: Zookeeper
> Issue Type: Improvement
> Reporter: Mahadev konar
> Assignee: Patrick Hunt
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-456.patch
>
>
> CREATOR_ALL_ACL has unnecessary PERMS.ADMIN in the declartion. The perms are
> defined as PERMS.ALL|PERMS.ADMIN. PERMS.ALL includes ADMIN, so the logical or
> is unnecessary.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
