[jira] Commented: (ZOOKEEPER-121) SyncRequestProcessor is not closing log stream during shutdown

[Benjamin Reed (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12844993#action_12844993
 ] 

Benjamin Reed commented on ZOOKEEPER-121:
-----------------------------------------

i think i agree with pat. we need to figure why it is happening.

looking more closely i believe the problem is in SyncRequestProcessor.shutdown.

currently it is

{code}
    public void shutdown() {
        try{
            zks.getZKDatabase().close();
        } catch (IOException ie) {
            LOG.warn("Error closing logs ", ie);
        }
        queuedRequests.add(requestOfDeath);
        nextProcessor.shutdown();
    }
{code}

i think we need to move up the requestOfDeath and wait for shutdown before 
closing:

{code}
    public void shutdown() {
        queuedRequests.add(requestOfDeath);
        this.join();
        try{
            zks.getZKDatabase().close();
        } catch (IOException ie) {
            LOG.warn("Error closing logs ", ie);
        }
        nextProcessor.shutdown();
    }
{code}

> SyncRequestProcessor is not closing log stream during shutdown
> --------------------------------------------------------------
>
>                 Key: ZOOKEEPER-121
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-121
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: server
>            Reporter: Patrick Hunt
>            Assignee: Mahadev konar
>            Priority: Blocker
>             Fix For: 3.3.0
>
>         Attachments: ZOOKEEPER-121.patch, ZOOKEEPER-121.patch, 
> ZOOKEEPER-121.patch
>
>
> The SyncRequestProcessor is not closing log stream during shutdown. 
> See FIXMEs with this ID in ClientBase.java -- I've commented out the 
> assertion for the time being (checking for logs being deleted), as part of 
> this fix re-enable these asserts and also verify tests on a Windows system.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.