[
https://issues.apache.org/jira/browse/ZOOKEEPER-758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12862768#action_12862768
]
Hadoop QA commented on ZOOKEEPER-758:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12443301/ZOOKEEPER-758.patch
against trunk revision 939172.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/79/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/79/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/79/console
This message is automatically generated.
> zkpython segfaults on invalid acl with missing key
> --------------------------------------------------
>
> Key: ZOOKEEPER-758
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-758
> Project: Zookeeper
> Issue Type: Bug
> Components: contrib-bindings
> Affects Versions: 3.3.0, 3.4.0
> Environment: ubuntu lucid (10.04)
> Reporter: Kapil Thangavelu
> Attachments: invalid-acl-fix-and-test.diff, ZOOKEEPER-758.patch,
> ZOOKEEPER-758.patch
>
>
> Currently when setting an acl, there is a minimal parse to ensure that its a
> list of dicts, however if one of the dicts is missing a required key, the
> subsequent usage doesn't check for it, and will segfault.. for example using
> an acl of [{"schema":id, "id":world, permissions:PERM_ALL}] will segfault if
> used, because the scheme key is missing (its been purposefully typo'd to
> schema in example).
> I've expanded the check_acl macro to include verifying that all keys are
> present and added some unit tests against trunk in the attachments.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
