[ https://issues.apache.org/jira/browse/ZOOKEEPER-763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12864539#action_12864539 ]
Hadoop QA commented on ZOOKEEPER-763: ------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12443769/ZOOKEEPER-763.patch against trunk revision 941473. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/149/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/149/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/149/console This message is automatically generated. > Deadlock on close w/ zkpython / c client > ---------------------------------------- > > Key: ZOOKEEPER-763 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-763 > Project: Zookeeper > Issue Type: Bug > Components: contrib-bindings > Affects Versions: 3.3.0 > Environment: ubuntu 10.04, zookeeper 3.3.0 and trunk > Reporter: Kapil Thangavelu > Assignee: Henry Robinson > Fix For: 3.3.1, 3.4.0 > > Attachments: deadlock.py, deadlock_v2.py, stack-trace-deadlock.txt, > ZOOKEEPER-763.patch, ZOOKEEPER-763.patch > > > deadlocks occur if we attempt to close a handle while there are any > outstanding async requests (aget, acreate, etc). Normally on close both the > io thread terminates and the completion thread are terminated and joined, > however w\ith outstanding async requests, the completion thread won't be in a > joinable state, and we effectively hang when the main thread does the join. > afaics ideal behavior would be on close of a handle, to effectively clear out > any remaining callbacks and let the completion thread terminate. > i've tried adding some bookkeeping to within a python client to guard against > closing while there is an outstanding async completion request, but its an > imperfect solution since even after the python callback is executed there is > still a window for deadlock before the completion thread finishes the > callback. > a simple example to reproduce the deadlock is attached. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.