[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12865234#action_12865234
 ] 

Patrick Hunt commented on ZOOKEEPER-769:
----------------------------------------

Hi Sergey, thanks for the patch, see this page for details on contributing:
http://wiki.apache.org/hadoop/ZooKeeper/HowToContribute

git is fine, but you need to use the "--no-prefix" option when doing the diff, 
otw the patch will fail with the automated verification of the patch.

also, in future it's good to name the patch after the jira ie 
ZOOKEEPER-769.patch, it helps reviewers and makes easier to keep track of many 
patches.

Regards.

> Leader can treat observers as quorum members
> --------------------------------------------
>
>                 Key: ZOOKEEPER-769
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-769
>             Project: Zookeeper
>          Issue Type: Bug
>    Affects Versions: 3.3.0
>         Environment: Ubuntu Karmic x64
>            Reporter: Sergey Doroshenko
>            Assignee: Sergey Doroshenko
>             Fix For: 3.4.0
>
>         Attachments: follower.log, leader.log, observer.log, warning.patch, 
> zoo1.cfg
>
>
> In short: it seems leader can treat observers as quorum members.
> Steps to repro:
> 1. Server configuration: 3 voters, 2 observers (attached).
> 2. Bring up 2 voters and one observer. It's enough for quorum.
> 3. Shut down the one from the quorum who is the follower.
> As I understand, expected result is that leader will start a new election 
> round so that to regain quorum.
> But the real situation is that it just says goodbye to that follower, and is 
> still operable. (When I'm shutting down 3rd one -- observer -- leader starts 
> trying to regain a quorum).
> (Expectedly, if on step 3 we shut down the leader, not the follower, 
> remaining follower starta new leader election, as it should be).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to