[
https://issues.apache.org/jira/browse/ZOOKEEPER-767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrick Hunt updated ZOOKEEPER-767:
-----------------------------------
Status: Open (was: Patch Available)
Hi Sam, putting one's own copyright notice as done in this latest patch is
against Apache policy (sort of like how we don't allow @author tags in the
javadoc). One problem is that then everyone who patches the file is tempted to
add a copyright for their contributions, this gets ugly fast. We don't try to
fully document the reality of the copyright ownership in the source however the
commit log / scm will document it, though.
Also what you've added for the license is not the normal Apache boilerplate. It
does not include the reference to NOTICE for copyright info like it should, it
should also be at the very top of the file.
Please update your patch with the following file header. (should be at the top
of each source file, see the other files in this directory for examples).
Thanks!
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
> Submitting Demo/Recipe Shared / Exclusive Lock Code
> ---------------------------------------------------
>
> Key: ZOOKEEPER-767
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-767
> Project: Zookeeper
> Issue Type: Improvement
> Components: recipes
> Affects Versions: 3.3.0
> Reporter: Sam Baskinger
> Assignee: Sam Baskinger
> Priority: Minor
> Fix For: 3.4.0
>
> Attachments: ZOOKEEPER-767.patch
>
>
> Networked Insights would like to share-back some code for shared/exclusive
> locking that we are using in our labs.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
