[
https://issues.apache.org/jira/browse/ZOOKEEPER-744?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12882759#action_12882759
]
Hadoop QA commented on ZOOKEEPER-744:
-------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12448091/ZOOKEEPER-744.patch
against trunk revision 958096.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 12 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/122/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/122/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/122/console
This message is automatically generated.
> Add monitoring four-letter word
> -------------------------------
>
> Key: ZOOKEEPER-744
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-744
> Project: Zookeeper
> Issue Type: New Feature
> Components: server
> Affects Versions: 3.4.0
> Reporter: Travis Crawford
> Assignee: Andrei Savu
> Fix For: 3.4.0
>
> Attachments: zk-ganglia.png, ZOOKEEPER-744.patch,
> ZOOKEEPER-744.patch, ZOOKEEPER-744.patch, ZOOKEEPER-744.patch
>
>
> Filing a feature request based on a zookeeper-user discussion.
> Zookeeper should have a new four-letter word that returns key-value pairs
> appropriate for importing to a monitoring system (such as Ganglia which has a
> large installed base)
> This command should initially export the following:
> (a) Count of instances in the ensemble.
> (b) Count of up-to-date instances in the ensemble.
> But be designed such that in the future additional data can be added. For
> example, the output could define the statistic in a comment, then print a key
> "space character" value line:
> """
> # Total number of instances in the ensemble
> zk_ensemble_instances_total 5
> # Number of instances currently participating in the quorum.
> zk_ensemble_instances_active 4
> """
> From the mailing list:
> """
> Date: Mon, 19 Apr 2010 12:10:44 -0700
> From: Patrick Hunt <[email protected]>
> To: [email protected]
> Subject: Re: Recovery issue - how to debug?
> On 04/19/2010 11:55 AM, Travis Crawford wrote:
> > It would be a lot easier from the operations perspective if the leader
> > explicitly published some health stats:
> >
> > (a) Count of instances in the ensemble.
> > (b) Count of up-to-date instances in the ensemble.
> >
> > This would greatly simplify monitoring& alerting - when an instance
> > falls behind one could configure their monitoring system to let
> > someone know and take a look at the logs.
> That's a great idea. Please enter a JIRA for this - a new 4 letter word
> and JMX support. It would also be a great starter project for someone
> interested in becoming more familiar with the server code.
> Patrick
> """
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
