[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888240#action_12888240
 ] 

Hadoop QA commented on ZOOKEEPER-814:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12449427/ZOOKEEPER-814.patch
  against trunk revision 963957.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 4 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/143/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/143/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/143/console

This message is automatically generated.

> monitoring scripts are missing apache license headers
> -----------------------------------------------------
>
>                 Key: ZOOKEEPER-814
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-814
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: contrib
>            Reporter: Patrick Hunt
>            Assignee: Andrei Savu
>            Priority: Blocker
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-814.patch
>
>
> Andrei, I just realized that src/contrib/monitoring files are missing apache 
> license headers.  Please add them (in particular any script files like 
> python, see similar files in svn for examples - in some cases like README 
> it's not strictly necessary.) 
> You can run the RAT tool to verify (see build.xml or 
> http://incubator.apache.org/rat/)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to