[ https://issues.apache.org/jira/browse/ZOOKEEPER-804?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12903260#action_12903260 ]
Michi Mutsuzaki commented on ZOOKEEPER-804: ------------------------------------------- I haven't been able to reproduce it, but it looks like we shouldn't assert(cptr) if zookeeper_close has been called (zookeeper.c line 1950). Can we do something like: completion_list_t *cptr = dequeue_completion(&zh->sent_requests); if (zh->close_requested == 1) { // zookeeper_close has been called. No need to assert cptr. Just free it if it's not NULL if (cptr) { destroy_completion_entry(cptr); } // some more cleanup? return ZINVALIDSTATE; } // zookeeper_close hadn't been called when we called dequeue_completion. cptr must not be NULL. assert(cptr); --Michi > c unit tests failing due to "assertion cptr failed" > --------------------------------------------------- > > Key: ZOOKEEPER-804 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-804 > Project: Zookeeper > Issue Type: Bug > Components: c client > Affects Versions: 3.4.0 > Environment: gcc 4.4.3, ubuntu lucid lynx, dual core laptop (intel) > Reporter: Patrick Hunt > Assignee: Mahadev konar > Priority: Critical > Fix For: 3.3.2, 3.4.0 > > > I'm seeing this frequently: > [exec] Zookeeper_simpleSystem::testPing : elapsed 18006 : OK > [exec] Zookeeper_simpleSystem::testAcl : elapsed 1022 : OK > [exec] Zookeeper_simpleSystem::testChroot : elapsed 3145 : OK > [exec] Zookeeper_simpleSystem::testAuth ZooKeeper server started : > elapsed 25687 : OK > [exec] zktest-mt: > /home/phunt/dev/workspace/gitzk/src/c/src/zookeeper.c:1952: > zookeeper_process: Assertion `cptr' failed. > [exec] make: *** [run-check] Aborted > [exec] Zookeeper_simpleSystem::testHangingClient > Mahadev can you take a look? -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.