[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-823?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Thomas Koch updated ZOOKEEPER-823:
----------------------------------

    Attachment: ZOOKEEPER-823.patch

changes:

- call ClientCnxn.cleanup() from ClientCnxnSocketNIO.cleanup(), was lost during 
the refactoring
- cleaned the formatting changes to make the patch smaller

Now there are only three failures left:
NettyNettySuiteTest - ACLTest.testAcls
KeeperErrorCode = ConnectionLoss for /0
org.apache.zookeeper.KeeperException$ConnectionLossException: KeeperErrorCode = 
ConnectionLoss for /0
        at org.apache.zookeeper.KeeperException.create(KeeperException.java:90)
        at org.apache.zookeeper.KeeperException.create(KeeperException.java:42)
        at org.apache.zookeeper.ZooKeeper.create(ZooKeeper.java:640)
        at org.apache.zookeeper.test.ACLTest.testAcls(ACLTest.java:104)
        at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:51)

When I run the whole suite in eclipse as JUnit test, it does not fail.

NettyNettySuiteHammerTest - The log doesn't tell me anything, I assume it's 
just the same as in NettyNettySuiteTest

NioNettySuiteTest - ClientTest.testClientCleanup
open fds after test are not significantly higher than before
junit.framework.AssertionFailedError: open fds after test are not significantly 
higher than before
        at 
org.apache.zookeeper.test.ClientTest.testClientCleanup(ClientTest.java:731)
        at 
org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:51)

When I run the whole suite in eclipse, the test still fails, however when I run 
only ClientTest.testClientCleanup alone, it does not fail anymore.

I would really appreciate, if you could help me from now on. I double, partly 
triple checked the refactoring.

> update ZooKeeper java client to optionally use Netty for connections
> --------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-823
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-823
>             Project: Zookeeper
>          Issue Type: New Feature
>          Components: java client
>            Reporter: Patrick Hunt
>            Assignee: Patrick Hunt
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-823.patch, ZOOKEEPER-823.patch, 
> ZOOKEEPER-823.patch, ZOOKEEPER-823.patch, ZOOKEEPER-823.patch
>
>
> This jira will port the client side connection code to use netty rather than 
> direct nio.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to