Use SelectionKey.isXYZ() methods instead of complicated binary logic
--------------------------------------------------------------------
Key: ZOOKEEPER-910
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-910
Project: Zookeeper
Issue Type: Sub-task
Reporter: Thomas Koch
Fix For: 3.4.0
The SelectionKey class provides methods to replace something like this
(k.readyOps() & (SelectionKey.OP_READ | SelectionKey.OP_WRITE)) != 0
with
selectionKey.isReadable() || selectionKey.isWritable()
It may be possible, that the first version saves a CPU cycle or two, but the
later version saves developer brain cycles which are much more expensive.
I suppose that there are many more places in the server code where this
replacement could be done. I propose that whoever touches a code line like this
should make the replacement.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
