[ https://issues.apache.org/jira/browse/ZOOKEEPER-934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12933719#action_12933719 ]
Flavio Junqueira commented on ZOOKEEPER-934: -------------------------------------------- One more comment. Looking at the logs for ZOOKEEPER-880, I remembered that in their case the RecvWorker thread was able to read a valid id from the connection with a Nagios server. I'm not exactly sure how that happened, but that essentially tells that the simple check you proposed might not do it. We don't want a Nagios box impersonating a ZooKeeper server! :-) > Add sanity check for server ID > ------------------------------ > > Key: ZOOKEEPER-934 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-934 > Project: Zookeeper > Issue Type: Sub-task > Reporter: Vishal K > Fix For: 3.4.0 > > > 2. Should I add a check to reject connections from peers that are not > listed in the configuration file? Currently, we are not doing any > sanity check for server IDs. I think this might fix ZOOKEEPER-851. > The fix is simple. However, I am not sure if anyone in community > is relying on this ability. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.