Charlie Clark wrote:
> Am 11.11.2008 um 16:52 schrieb yuppie:
> 
>> AFAICT PortalFolder inherits from CMFCatalogAware to make sure it has
>> the same manage_afterAdd, manage_afterClone and manage_beforeDelete
>> methods as other content classes. But these methods are gone, so I  
>> guess
>> the dependency is no longer needed.
> 
> You didn't hear it from me but this is surely abuse of inheritance?  
> Time to call the cops and stand outside our houses in dressing gowns  
> and slippers tutting and looking superior!

This is the checkin that added CMFCatalogAware to PortalFolder:
http://svn.zope.org/?rev=35114&view=rev

It explains why and how it was done. Maybe a first step to clean this up 
would be to split CMFCatalogAware into separate mixins.

Cheers, Yuppie

_______________________________________________
Zope-CMF maillist  -  Zope-CMF@lists.zope.org
http://mail.zope.org/mailman/listinfo/zope-cmf

See https://bugs.launchpad.net/zope-cmf/ for bug reports and feature requests

Reply via email to