On Mar 4, 2009, at 2:20 AM, Thomas Lotze wrote: > Gary Poster <gary.pos...@gmail.com> schrieb: > >>> Index: src/zc/dict/configure.zcml >>> =================================================================== >>> --- src/zc/dict/configure.zcml (.../trunk) (revision 0) >>> +++ src/zc/dict/configure.zcml (.../branches/tlotze-blist) >> (revision 97211) >>> @@ -0,0 +1,5 @@ >>> +<configure xmlns="http://namespaces.zope.org/zope";> >>> + >>> + <include package=".generations" /> >>> + >>> +</configure> >> >> configure.zcml has a semantic of "always include." Because the >> generations code may not work for many people (as we've discussed >> before, and see comment in evolve test below), I'd prefer that the >> generations code have a semantic of "optionally include." Therefore, >> I suggest you rename this to "generations.zcml" or something like >> that. > > Wouldn't it be simpler to just remove this file as it does nothing but > include the configure.zcml of a sub-package? Using the generations > configuration would then read <include > package="zc.dict.generations" /> > instead of <include package="zc.dict" file="generations.zcml" /> which > wouldn't be for the worse either IMO.
+1, good idea >> Also as mentioned before on the Zope list, until this API is >> deprecated in favor of one that encourages more granular changes, the >> change to blist only really helps the story for adding new items to >> an >> ordered dict. >> >> The Plone IExplicitOrdering interface looks reasonable, and could >> really take advantage of the blist characteristics. > > I do have that on my to-do list. Do you think we should add some > comment > about this to the code? I think the current performance characteristics are important to note somewhere, at least. Even CHANGES would be sufficient. Thanks, Gary _______________________________________________ Zope-Dev maillist - Zope-Dev@zope.org http://mail.zope.org/mailman/listinfo/zope-dev ** No cross posts or HTML encoding! ** (Related lists - http://mail.zope.org/mailman/listinfo/zope-announce http://mail.zope.org/mailman/listinfo/zope )
