> IMO, you didn't *need* to add any comment to the merge proposal other than > "Bugs filed" -- I can read the bugs myself. FYI: Matthias asked me (in a separate email discussion) to add a small review of the issues I fount in the merge proposal: please take this issue with him.
> Sorin wrote: "Keep in mind that I have spent my time in order to give you a > hand in pointing out the issues I found." > > It's all of our job to review each others' code under the "New Order" so > please don't act like it was a personal favor. OK, next time I will review your code I will simply add a one sentence in the merge proposal and keep adding comments because you clearly think this is better. > I never questioned your adding separate bugs. For the record, I *like* > separate bugs. I *only* questioned why you added EXPECTED_FAILURE for those > bugs that, as I've pointed out, is unnecessary and not only creates more work > for you (because you put them in) but more work for me (because I have to take > them out). I will never do this again. > Sorin wrote: "And to prove my point: you already wrote 2 comments *without* > even looking over *any* of the issues I have raised." > > *My* point has *nothing* to do with any bugs in particular. Chris understands > my point. Do you? No, I do not. IMHO you are missing the point, that is: let's try to fix the *bugs* and discuss the procedures later. Do you understand my point? -- https://code.launchpad.net/~zorba-coders/zorba/feature-json_parser/+merge/89616 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
