> - The indentation has several problems. Could you please make it consistent. > Especially in the C++ code.
sure. > - Why don't you use the same approach as we did for xbrl-cloud and keep the > connection map in JSONiq (using the map module)? I think that would be more > appropriate for this module than replicating 400 lines of c++ code. If this is > a recurring pattern, we might think about providing core support for it but I > feel that the JSONiq map is good enough for now. Also, I wouldn't worry about > the disconnect at this point. When the story was discussed I was suggested to manage connections as the JDBC module does. But I probably misunderstood. I updated the code to manage connection from XQuery and removed all c++ code. -- https://code.launchpad.net/~zorba-coders/zorba/feature-cloudant/+merge/177111 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
