Review: Approve Looks great. I'll approve and let you decide on one question:
Is it really necessary to make the expressions in the parsenodes non-const? Couldn't you use a unique pointer or auto_ptr in the parser that is passed to convert_postfix_to_target_and_selector and only released when the JSON expression is created? -- https://code.launchpad.net/~zorba-coders/zorba/new-jsoniq-update/+merge/185295 Your team Zorba Coders is subscribed to branch lp:zorba. -- Mailing list: https://launchpad.net/~zorba-coders Post to : zorba-coders@lists.launchpad.net Unsubscribe : https://launchpad.net/~zorba-coders More help : https://help.launchpad.net/ListHelp
