gengliangwang commented on PR #46450:
URL: https://github.com/apache/spark/pull/46450#issuecomment-2101980217
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
gengliangwang closed pull request #46450: [SPARK-48182][SQL] SQL (java side):
Migrate `error/warn/info` with variables to structured logging framework
URL: https://github.com/apache/spark/pull/46450
--
This is an automated message from the Apache Git Service.
To respond to the message,
gengliangwang commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1594975187
##
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java:
##
@@ -210,8 +218,9 @@ public synchronized void stop() {
gengliangwang commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1594974489
##
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java:
##
@@ -210,8 +218,9 @@ public synchronized void stop() {
panbingkun commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1594924012
##
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/ClassicTableTypeMapping.java:
##
@@ -69,7 +72,8 @@ public ClassicTableTypeMapping() {
gengliangwang commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1594919483
##
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/ClassicTableTypeMapping.java:
##
@@ -69,7 +72,8 @@ public ClassicTableTypeMapping()
panbingkun commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1594904005
##
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/ClassicTableTypeMapping.java:
##
@@ -69,7 +72,8 @@ public ClassicTableTypeMapping() {
panbingkun commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1594903795
##
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java:
##
@@ -210,8 +218,9 @@ public synchronized void stop() {
try
panbingkun commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1594903597
##
sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java:
##
@@ -285,9 +288,10 @@ public String verifyDelegationToken(String
gengliangwang commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1594850880
##
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/operation/ClassicTableTypeMapping.java:
##
@@ -69,7 +72,8 @@ public ClassicTableTypeMapping()
gengliangwang commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1594850272
##
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java:
##
@@ -210,8 +218,9 @@ public synchronized void stop() {
gengliangwang commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1594846382
##
sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/HiveAuthFactory.java:
##
@@ -285,9 +288,10 @@ public String verifyDelegationToken(String
panbingkun commented on PR #46450:
URL: https://github.com/apache/spark/pull/46450#issuecomment-2100380424
cc @gengliangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
panbingkun commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1593883576
##
sql/hive-thriftserver/src/main/java/org/apache/hive/service/ServiceUtils.java:
##
@@ -18,7 +18,7 @@
import java.io.IOException;
-import org.slf4j.Logger;
panbingkun commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1593875379
##
common/utils/src/main/java/org/apache/spark/internal/Logger.java:
##
@@ -193,4 +193,8 @@ static MessageThrowable of(String message, Throwable
throwable) {
panbingkun commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1593871899
##
sql/hive-thriftserver/src/main/java/org/apache/hive/service/cli/session/SessionManager.java:
##
@@ -84,13 +87,15 @@ public synchronized void init(HiveConf
panbingkun commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1593843557
##
sql/hive-thriftserver/src/main/java/org/apache/hive/service/ServiceOperations.java:
##
@@ -129,9 +132,8 @@ public static Exception stopQuietly(Service service) {
panbingkun commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1593840887
##
sql/hive-thriftserver/src/main/java/org/apache/hive/service/auth/TSetIpAddressProcessor.java:
##
@@ -38,7 +39,7 @@
*/
public class TSetIpAddressProcessor
panbingkun commented on code in PR #46450:
URL: https://github.com/apache/spark/pull/46450#discussion_r1593836057
##
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLCLIService.scala:
##
@@ -33,8 +33,8 @@ import
panbingkun opened a new pull request, #46450:
URL: https://github.com/apache/spark/pull/46450
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How
20 matches
Mail list logo
