gengliangwang closed pull request #46390: [SPARK-48134][CORE] Spark core (java
side): Migrate `error/warn/info` with variables to structured logging framework
URL: https://github.com/apache/spark/pull/46390
--
This is an automated message from the Apache Git Service.
To respond to the
gengliangwang commented on PR #46390:
URL: https://github.com/apache/spark/pull/46390#issuecomment-2099214104
Thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
panbingkun commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1591909956
##
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java:
##
@@ -17,21 +17,22 @@
package
gengliangwang commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1591907044
##
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java:
##
@@ -17,21 +17,22 @@
package
panbingkun commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1591904228
##
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java:
##
@@ -17,21 +17,22 @@
package
gengliangwang commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1591854610
##
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java:
##
@@ -476,8 +479,9 @@ public void insertRecord(
gengliangwang commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1591851400
##
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeSorterSpillReader.java:
##
@@ -17,21 +17,22 @@
package
panbingkun commented on PR #46390:
URL: https://github.com/apache/spark/pull/46390#issuecomment-2097183311
@gengliangwang
All done.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
panbingkun commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1591674796
##
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java:
##
@@ -216,11 +218,11 @@ public long spill(long size, MemoryConsumer
panbingkun commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1591654185
##
core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java:
##
@@ -205,7 +208,7 @@ private void closeUnderlyingInputStreamIfNecessary() {
try {
panbingkun commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1591654034
##
core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java:
##
@@ -42,7 +45,7 @@
*/
public class ReadAheadInputStream extends InputStream {
- private
gengliangwang commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1591437324
##
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java:
##
@@ -216,11 +218,11 @@ public long spill(long size,
gengliangwang commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1591388245
##
core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java:
##
@@ -42,7 +45,7 @@
*/
public class ReadAheadInputStream extends InputStream {
-
gengliangwang commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1591354244
##
core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java:
##
@@ -205,7 +208,7 @@ private void closeUnderlyingInputStreamIfNecessary() {
try {
panbingkun commented on PR #46390:
URL: https://github.com/apache/spark/pull/46390#issuecomment-2095704061
cc @gengliangwang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
panbingkun commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1590759422
##
core/src/main/java/org/apache/spark/memory/TaskMemoryManager.java:
##
@@ -195,9 +197,9 @@ public long acquireExecutionMemory(long required,
MemoryConsumer
panbingkun commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1590756776
##
core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java:
##
@@ -42,7 +45,7 @@
*/
public class ReadAheadInputStream extends InputStream {
- private
panbingkun commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1590749736
##
core/src/main/java/org/apache/spark/io/ReadAheadInputStream.java:
##
@@ -13,13 +13,6 @@
*/
package org.apache.spark.io;
-import
panbingkun commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1590748268
##
common/utils/src/main/java/org/apache/spark/internal/Logger.java:
##
@@ -34,10 +34,26 @@ public class Logger {
this.slf4jLogger = slf4jLogger;
}
+
panbingkun commented on code in PR #46390:
URL: https://github.com/apache/spark/pull/46390#discussion_r1590745356
##
common/utils/src/main/java/org/apache/spark/internal/Logger.java:
##
@@ -34,10 +34,26 @@ public class Logger {
this.slf4jLogger = slf4jLogger;
}
+
panbingkun opened a new pull request, #46390:
URL: https://github.com/apache/spark/pull/46390
### What changes were proposed in this pull request?
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
### How was this
21 matches
Mail list logo
