On Tue, 19 Mar 2024 17:58:46 GMT, Bill Huang <bhu...@openjdk.org> wrote:
>> This task addresses an essential aspect of our testing infrastructure: the
>> proper handling and cleanup of temporary files and socket files created
>> during test execution. The motivation behind these changes is to prevent the
>> accumulation of unnecessary files in the default temporary directory, which
>> can affect the system's storage and potentially influence subsequent test
>> runs.
>>
>> Our review identified that several tests create temporary files or socket
>> files without ensuring their removal post-execution.
>> - Direct calls to java.io.File.createTempFile and
>> java.nio.file.Files.createTempFile without adequate cleanup.
>> - Tests using NIO socket channels with StandardProtocolFamily.UNIX, not
>> explicitly removing socket files post-use.
>
> Bill Huang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Implemented review comments
test/jdk/java/nio/channels/unixdomain/Bind.java line 201:
> 199: System.out.println("Null server address: " +
> server.getLocalAddress());
> 200: } finally {
> 201: Files.deleteIfExists(usa.getPath());
`usa` can be `null` here, if it never got assigned due to some exception in the
prior lines, which can lead to a `NullPointerException` here.
test/jdk/java/nio/channels/unixdomain/Bind.java line 341:
> 339: assertAddress(client.getRemoteAddress(), usa, "server");
> 340: } finally {
> 341: Files.deleteIfExists(usa.getPath());
Same applies here about potential NullPointerException and some other places in
other files as well.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18352#discussion_r1534092806
PR Review Comment: https://git.openjdk.org/jdk/pull/18352#discussion_r1534095046
