On Wed, 15 May 2024 16:11:56 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Switch to monomorphic StableValue and use lazy arrays > > src/java.base/share/classes/jdk/internal/lang/stable/StableValueImpl.java > line 139: > >> 137: case NON_NULL: { return valueVolatile(); } >> 138: case ERROR: { throw StableUtil.error(this); } >> 139: case DUMMY: { throw shouldNotReachHere(); } > > Redundant branch? The idea here is to have the most likely value in the middle... Not sure if that motivates the added complexity though. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18794#discussion_r1602739126