On Wed, 15 May 2024 16:29:08 GMT, Chen Liang <li...@openjdk.org> wrote:
>> Per Minborg has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Switch to monomorphic StableValue and use lazy arrays > > src/java.base/share/classes/jdk/internal/lang/stable/StableValueImpl.java > line 236: > >> 234: } catch (Throwable t) { >> 235: putState(ERROR); >> 236: putMutex(t.getClass()); > > Should we cache the exception instance so we can rethrow it in future ERROR > state `orThrow` calls? We considered recording the entire exception instance but for security reasons, we ended up just recording the type of exception. I will add a comment explaining this in the code. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18794#discussion_r1602793832