Gregg,

On 6/13/14, 2:04 PM, Gregg Smith wrote:
> On 6/13/2014 10:16 AM, Christopher Schultz wrote:
>>>>
>>>> Yeah, I'd like something that I can script. Right now, there's
>>>> basically
>>>> one guy who knows how to build tcnative on win32. We're trying to
>>>> change
>>>> that ;)
>>>>
> 
> I'm going to blindly assume scripting using a batch file which something
> I forgot to think about was dealing with the files that need to be
> changed. In this case there's always sed and being a *nix person I'm
> sure you know how to use it better than I and that can be done in the
> batch file.

I'll already have 'patch' available. It seems cleaner and will catch
more errors.

> Something I forgot to mention, if you need APR IPv6 compatible you will
> have to flip that switch in apr\include\apr.hw
> 
> #define APR_HAVE_IPV6           0

Looks like we already have a patch for that in tcnative:

$ cat native/srclib/apr/apr-enable-ipv6.patch
--- include/apr.hw
+++ include/apr.hw
@@ -276,7 +276,7 @@
 #define APR_HAVE_IN_ADDR        1
 #define APR_HAVE_INET_ADDR      1
 #define APR_HAVE_INET_NETWORK   0
-#define APR_HAVE_IPV6           0
+#define APR_HAVE_IPV6           1
 #define APR_HAVE_MEMMOVE        1
 #define APR_HAVE_SETRLIMIT      0
 #define APR_HAVE_SIGACTION      0
@@ -340,7 +340,7 @@
 /* If we have a TCP implementation that can be "corked", what flag
  * do we use?
  */
-#define APR_TCP_NOPUSH_FLAG       @apr_tcp_nopush_flag@
+#define APR_TCP_NOPUSH_FLAG       0

 /* Is the TCP_NODELAY socket option inherited from listening sockets?
  */


Thanks again!

-chris

Attachment: signature.asc
Description: OpenPGP digital signature

Reply via email to