Thanks Haisheng for driving this!

Verified GPG signature - OK
Verified SHA512 - OK
Release notes - OK
Diff the files in the release artifact and tag - ok

As for Calcite 3997, it only affects the Physical node,  I’m fine with that
~

So +1 (binding) ~

Gradle 6.3 (via gradlew)
Mac OS High Sierra
JDK version "1.8.0_151"

Forward Xu <forwardxu...@gmail.com>于2020年5月20日 周三上午9:38写道:

> Thanks, Haisheng!
>
>
> Environment: Mac-OS Mojave (10.14.6)
>
> JDK version: 1.8.0_211
>
>
> Release notes: OK
>
> Build with tests: OK
>
> Checksums and signatures: OK
>
>
> Vote:
>
> +1 (non-binding)
>
>
> Best,
>
> Forward
>
> XING JIN <jinxing.co...@gmail.com> 于2020年5月19日周二 上午10:53写道:
>
> > Thanks, Haisheng ~
> >
> > Local Calcite build with tests enabled on Linux: *OK*
> > Calcite-based system test suite: *OK*
> >
> > Vote:
> > +1 (non-binding)
> >
> > Francis Chuang <francischu...@apache.org> 于2020年5月18日周一 下午2:00写道:
> >
> > > Thanks for making this release available for voting, Haisheng!
> > >
> > > Verified GPG signature - OK
> > > Verified SHA512 - OK
> > > Ran tests per HOWTO (./gradlew check) - OK
> > > Quickly skimmed release notes - OK
> > > Spotted checked a few JARs in the Maven repository - OK
> > >
> > > Environment (OpenJDK:latest docker container):
> > > Gradle 6.3 (via gradlew)
> > > Debian GNU/Linux 8
> > > openjdk version "1.8.0_111"
> > > OpenJDK Runtime Environment (build 1.8.0_111-8u111-b14-2~bpo8+1-b14)
> > > OpenJDK 64-Bit Server VM (build 25.111-b14, mixed mode)
> > >
> > > My vote is: +1 (binding)
> > >
> > > Francis
> > >
> > > On 16/05/2020 2:02 pm, Haisheng Yuan wrote:
> > > > Hi all,
> > > >
> > > > I have created a build for Apache Calcite 1.23.0, release
> > > > candidate 1.
> > > >
> > > > Thanks to everyone who has contributed to this release.
> > > >
> > > > You can read the release notes here:
> > > >
> > >
> >
> https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md
> > > >
> > > > The commit to be voted upon:
> > > >
> > >
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
> > > >
> > > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3
> > > >
> > > > Tag:
> > > > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1
> > > >
> > > > The artifacts to be voted on are located here:
> > > >
> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1
> > > > (revision 39622)
> > > >
> > > > The hashes of the artifacts are as follows:
> > > >
> > >
> >
> 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46
> > > > *apache-calcite-1.23.0-src.tar.gz
> > > >
> > > > A staged Maven repository is available for review at:
> > > >
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/
> > > >
> > > > Release artifacts are signed with the following key:
> > > > https://dist.apache.org/repos/dist/release/calcite/KEYS
> > > >
> > > > N.B.
> > > > To create the jars and test Apache Calcite: "./gradlew build".
> > > >
> > > > If you do not have a Java environment available, you can run the
> tests
> > > > using docker. To do so, install docker and docker-compose, then run
> > > > "docker-compose run test" from the root of the directory.
> > > >
> > > > Please vote on releasing this package as Apache Calcite 1.23.0.
> > > >
> > > > The vote is open for the next 72 hours and passes if a majority of at
> > > > least three +1 PMC votes are cast.
> > > >
> > > > [ ] +1 Release this package as Apache Calcite 1.23.0
> > > > [ ]  0 I don't feel strongly about it, but I'm okay with the release
> > > > [ ] -1 Do not release this package because...
> > > >
> > > >
> > > > Here is my vote:
> > > >
> > > > +1 (binding)
> > > >
> > > > Thanks,
> > > > Haisheng Yuan
> > > >
> > >
> >
>

Reply via email to