> * the first line printed by gradle is ':jar: No valid plugin > descriptors were found in META-INF/gradle-plugins'; I don't know > whether this is bad, but it looks bad
Looks like it is expected: https://github.com/gradle/gradle/issues/9758 On 2020/05/21 18:41:41, Julian Hyde <jh...@apache.org> wrote: > -1 because of signature issues noted in previous email (hoping I'm mistaken). > > Downloaded, checked build instructions, LICENSE, NOTICE, ran RAT, > compiled and ran tests using gradlew (Ubuntu 20.04 and JDK 14), > compared contents of source distro with contents of git. > > * howto.md doesn't mention JDK 14 as a valid release > * the line 'cd calcite-1.23.0' should be 'cd apache-calcite-1.23.0-src' > * the first line printed by gradle is ':jar: No valid plugin > descriptors were found in META-INF/gradle-plugins'; I don't know > whether this is bad, but it looks bad > * following the instructions in howto.md builds a release > '1.23.0-SNAPSHOT'; instructions should say how to build '1.23.0' > * LICENSE file in the source distro has a few extra lines compared to > the one in git > * in release notes: > ** 'fastest version of Calcite' is a bit hyperbolic; I would state > that there have been performance improvements in the planner engine > and hyperlink to a JIRA case > ** I think quite a few of the 'new features' that extend an existing > component to a new class (e.g supporting Exchange in RelFieldTrimmer) > should be listed as bug-fixes; > ** all class names need to be in back-ticks; all SQL keywords need to > be upper-case and in back-ticks; > ** I don't like the long lines - can we go back to breaking at 80? > ** In 'it's worth mentioning the following', remove JIRA case numbers > so that the paragraph reads like prose rather than a list. > > > On Thu, May 21, 2020 at 10:57 AM Julian Hyde <jh...@apache.org> wrote: > > > > Maybe I'm mistaken, but the source tarball doesn't seem to be signed: > > > > $ gpg --verify apache-calcite-1.23.0-src.tar.gz.asc > > apache-calcite-1.23.0-src.tar.gz > > gpg: Signature made Fri 15 May 2020 08:52:43 PM PDT > > gpg: using RSA key ECA9CF33AF2CEC28F3B66A5C3CD22ABAC50DDCEF > > gpg: Can't check signature: No public key > > > > I have imported Haisheng's keys successfully: > > > > $ gpg --recv-keys "A663 E308 27C3 5F7C F578 B4F0 41CA B58D 1DA9 7F7D" > > gpg: key 41CAB58D1DA97F7D: "Haisheng Yuan <hy...@apache.org>" not changed > > gpg: Total number processed: 1 > > gpg: unchanged: 1 > > > > Julian > > > > On Wed, May 20, 2020 at 10:12 PM Rui Wang <amaliu...@apache.org> wrote: > > > > > > I built the site both from the repo (git tag) and > > > apache-calcite-1.23.0-src.tar.gz, launched the site locally and spot > > > checked. From what I could tell, there wasn't an obvious difference > > > (random > > > clicks were limited though). > > > > > > My personal opinion is that the 1.23.0 rc1 can continue. If someone knows > > > the exact impact of this diff, we could add it to the release note, in the > > > category of "known issues". > > > > > > > > > -Rui > > > > > > On Wed, May 20, 2020 at 9:33 PM Rui Wang <amaliu...@apache.org> wrote: > > > > > > > Indeed there is an extra site/fonts in the git tag. I didn't see it in > > > > the > > > > last two releases (the diff on licenses are normal). > > > > > > > > So the question is, does it matter for the diff on site/? At least the > > > > artifact has the same source code as the tag (thus can build the same > > > > jar, > > > > behave the same when run same queries, etc.) Also the site/ seems not > > > > related to javadoc either. > > > > > > > > > > > > -Rui > > > > > > > > On Wed, May 20, 2020 at 3:53 PM Stamatis Zampetakis <zabe...@gmail.com> > > > > wrote: > > > > > > > >> 5.3.0-51-generic #44~18.04.2-Ubuntu, jdk1.8.0_251, Gradle wrapper > > > >> > > > >> * Checked signatures and checksums OK > > > >> * Build (./gradlew clean assemble) on git repo and source artifacts OK > > > >> * Run unit tests (./gradlew clean test) on git repo and source > > > >> artifacts > > > >> OK > > > >> * Run slow tests (./gradlew clean testSlow) on git repo and source > > > >> artifacts OK > > > >> * Checked diff between git commit and source artifacts > > > >> Apart from some differences in the licenses I see that the git tag has > > > >> a > > > >> folder site/fonts while the source artifacts do not. > > > >> * Went over release note OK > > > >> > > > >> The following issues should be added in the breaking changes section: > > > >> https://issues.apache.org/jira/browse/CALCITE-3825 > > > >> https://issues.apache.org/jira/browse/CALCITE-3938 > > > >> > > > >> There are few typos and other minor improvements (like quoting SQL > > > >> keywords > > > >> and java classes) for the release note but all these can be done > > > >> post-release. > > > >> > > > >> My only concern for casting my vote is the site/fonts folder that is > > > >> present on the repo. I don't remember seeing this in the previous > > > >> releases. > > > >> Can somebody clarify if this is normal? > > > >> > > > >> Thanks again for your effort Haisheng! > > > >> > > > >> Best, > > > >> Stamatis > > > >> > > > >> On Wed, May 20, 2020 at 3:13 PM Danny Chan <danny0...@apache.org> > > > >> wrote: > > > >> > > > >> > Thanks Haisheng for driving this! > > > >> > > > > >> > Verified GPG signature - OK > > > >> > Verified SHA512 - OK > > > >> > Release notes - OK > > > >> > Diff the files in the release artifact and tag - ok > > > >> > > > > >> > As for Calcite 3997, it only affects the Physical node, I’m fine > > > >> > with > > > >> that > > > >> > ~ > > > >> > > > > >> > So +1 (binding) ~ > > > >> > > > > >> > Gradle 6.3 (via gradlew) > > > >> > Mac OS High Sierra > > > >> > JDK version "1.8.0_151" > > > >> > > > > >> > Forward Xu <forwardxu...@gmail.com>于2020年5月20日 周三上午9:38写道： > > > >> > > > > >> > > Thanks, Haisheng! > > > >> > > > > > >> > > > > > >> > > Environment: Mac-OS Mojave (10.14.6) > > > >> > > > > > >> > > JDK version: 1.8.0_211 > > > >> > > > > > >> > > > > > >> > > Release notes: OK > > > >> > > > > > >> > > Build with tests: OK > > > >> > > > > > >> > > Checksums and signatures: OK > > > >> > > > > > >> > > > > > >> > > Vote: > > > >> > > > > > >> > > +1 (non-binding) > > > >> > > > > > >> > > > > > >> > > Best, > > > >> > > > > > >> > > Forward > > > >> > > > > > >> > > XING JIN <jinxing.co...@gmail.com> 于2020年5月19日周二 上午10:53写道： > > > >> > > > > > >> > > > Thanks, Haisheng ~ > > > >> > > > > > > >> > > > Local Calcite build with tests enabled on Linux: *OK* > > > >> > > > Calcite-based system test suite: *OK* > > > >> > > > > > > >> > > > Vote: > > > >> > > > +1 (non-binding) > > > >> > > > > > > >> > > > Francis Chuang <francischu...@apache.org> 于2020年5月18日周一 下午2:00写道： > > > >> > > > > > > >> > > > > Thanks for making this release available for voting, Haisheng! > > > >> > > > > > > > >> > > > > Verified GPG signature - OK > > > >> > > > > Verified SHA512 - OK > > > >> > > > > Ran tests per HOWTO (./gradlew check) - OK > > > >> > > > > Quickly skimmed release notes - OK > > > >> > > > > Spotted checked a few JARs in the Maven repository - OK > > > >> > > > > > > > >> > > > > Environment (OpenJDK:latest docker container): > > > >> > > > > Gradle 6.3 (via gradlew) > > > >> > > > > Debian GNU/Linux 8 > > > >> > > > > openjdk version "1.8.0_111" > > > >> > > > > OpenJDK Runtime Environment (build > > > >> 1.8.0_111-8u111-b14-2~bpo8+1-b14) > > > >> > > > > OpenJDK 64-Bit Server VM (build 25.111-b14, mixed mode) > > > >> > > > > > > > >> > > > > My vote is: +1 (binding) > > > >> > > > > > > > >> > > > > Francis > > > >> > > > > > > > >> > > > > On 16/05/2020 2:02 pm, Haisheng Yuan wrote: > > > >> > > > > > Hi all, > > > >> > > > > > > > > >> > > > > > I have created a build for Apache Calcite 1.23.0, release > > > >> > > > > > candidate 1. > > > >> > > > > > > > > >> > > > > > Thanks to everyone who has contributed to this release. > > > >> > > > > > > > > >> > > > > > You can read the release notes here: > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> https://github.com/apache/calcite/blob/calcite-1.23.0-rc1/site/_docs/history.md > > > >> > > > > > > > > >> > > > > > The commit to be voted upon: > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > > >> > > > > > > > > >> > > > > > Its hash is b708fdc46d4c5fd4c5a6c7a398823318a7b4dce3 > > > >> > > > > > > > > >> > > > > > Tag: > > > >> > > > > > https://github.com/apache/calcite/tree/calcite-1.23.0-rc1 > > > >> > > > > > > > > >> > > > > > The artifacts to be voted on are located here: > > > >> > > > > > > > > >> > > > > > > >> > > > > >> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.23.0-rc1 > > > >> > > > > > (revision 39622) > > > >> > > > > > > > > >> > > > > > The hashes of the artifacts are as follows: > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> 961c4f13199e199c669a6168ba655a9492bdd80d644da375a684b732c0b628b8a2ffacea5da97c82e8702a8e3bf7a1f58784baa49509fb3c48ef593259e11f46 > > > >> > > > > > *apache-calcite-1.23.0-src.tar.gz > > > >> > > > > > > > > >> > > > > > A staged Maven repository is available for review at: > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> https://repository.apache.org/content/repositories/orgapachecalcite-1089/org/apache/calcite/ > > > >> > > > > > > > > >> > > > > > Release artifacts are signed with the following key: > > > >> > > > > > https://dist.apache.org/repos/dist/release/calcite/KEYS > > > >> > > > > > > > > >> > > > > > N.B. > > > >> > > > > > To create the jars and test Apache Calcite: "./gradlew > > > >> > > > > > build". > > > >> > > > > > > > > >> > > > > > If you do not have a Java environment available, you can run > > > >> > > > > > the > > > >> > > tests > > > >> > > > > > using docker. To do so, install docker and docker-compose, > > > >> > > > > > then > > > >> run > > > >> > > > > > "docker-compose run test" from the root of the directory. > > > >> > > > > > > > > >> > > > > > Please vote on releasing this package as Apache Calcite > > > >> > > > > > 1.23.0. > > > >> > > > > > > > > >> > > > > > The vote is open for the next 72 hours and passes if a > > > >> > > > > > majority > > > >> of > > > >> > at > > > >> > > > > > least three +1 PMC votes are cast. > > > >> > > > > > > > > >> > > > > > [ ] +1 Release this package as Apache Calcite 1.23.0 > > > >> > > > > > [ ] 0 I don't feel strongly about it, but I'm okay with the > > > >> > release > > > >> > > > > > [ ] -1 Do not release this package because... > > > >> > > > > > > > > >> > > > > > > > > >> > > > > > Here is my vote: > > > >> > > > > > > > > >> > > > > > +1 (binding) > > > >> > > > > > > > > >> > > > > > Thanks, > > > >> > > > > > Haisheng Yuan > > > >> > > > > > > > > >> > > > > > > > >> > > > > > > >> > > > > > >> > > > > >> > > > > >
