On Tue, Nov 30, 2010 at 4:44 PM, Filipe David Manana <fdman...@apache.org> wrote: >> >> Here is an updated patch. It now use a filter sandbox instead of >> patching the function and it fixes whitespaces. > > Why a separate function to init the filter_sandbox? It can be done at > the end of the existing init_sandbox() function (perhaps renaming it > to init_sandboxes). > > I would rename Filter.filter_view to Filter.view_filter or to > Filter.map_filter (doing the same in > src/couchdb/couch_query_servers.erl for naming consistency). > > 4) is still there (the debugging ?LOG_INFO line). > > Also, this patch should only contain the changes necessary to > implement the new feature. While all the whitespace and indentation > fixes (to comply with the wiki rules) are a welcome plus, they should > come in a separate patch imo. > Well I used filter_view for consistency, since we use filter_docs already, I don't think it need to be changed at this point. I've removed the log stuff.
Are we OK for such feature ? If yes, I will commit it. - benoit
