[1] was added as part of jira YUNIKORN-505. [2] was added as part of jira YUNIKORN-427.
Both are apache files: jiras have been logged to add the headers. [3] is a settings file. The comments should have been cleaned up when the settings were customised. I have filed a jira for the cleanup. The file was already in YuniKorn v0.10 Wilfred > On 30 Jul 2021, at 15:46, Justin Mclean <jus...@classsoftware.com> wrote: > > Hi, > > -1 (binding) as there files missing headers and a possible license issue. If > the licenses of these files are clarified my vote can change. > > I checked: > - incubating in name > - signatures and hashes are fine > - DISCLAIMER exists > - LICENSE may be OK, except this file? [3] > - NOTICE is fine > - No unexpected binary files > - A couple of files are missing ASF headers > > A couple of files are missing ASF headers, where did they come from and how > are these licensed? [1][2] > > Is this file actually an ASF file or is it a 3rd party file? [3] If it a 3rd > party file how is it licensed? > > Kind Regards, > Justin > > 1. /core/pkg/scheduler/mock_plugin_test.go > 2. /k8shim/test/e2e/predicates/predicates_test.go > 3. /web/src/polyfills.ts > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > Wilfred Spiegelenburg Staff Software Engineer <https://www.cloudera.com/>
