I see Bitnine is the company that donated the project AGE to Apache, so the header change seems to make sense?
On Sat, Oct 23, 2021 at 5:27 PM Justin Mclean <jus...@classsoftware.com> wrote: > Hi, > > Sorry but it’s -1 (binding) as there is no download page and the download > links on the home page do not have hashes and signatures. This was brought > up on this list recently and was asked to be corrected. Also see other > issues below. > > In the release: > - incubating in name > - signatures and hashes are fine > - LICENSE is missing information from [1][2] > - NOTICE is incorrect. There should be no need for "This product contains > software PostgreSQL…” unless headers have been replace with permission or > there was a software grant from PostgreSQL. This has previously been > mentioned (in vote on 0.4.0 release). Also see issue with [1][2]. > - If seem unlikely that [1][2] should have ASF headers? In general the > licensing of the file should stay as it is unless significant modifications > have ben done. Looking at the history it seems if was originally "Copyright > 2020 Bitnine Co., Ltd.” Why is this not mentioned in NOTICE? Was permission > given to change the headers? > - Probably similar issue with these file [3][4] > - No unexpected binary files > - unable to compile but assume that my setup. > src/backend/catalog/ag_graph.c:67:15: error: assigning to 'Oid' > (aka 'unsigned int') from incompatible type 'void' > > Kind Regards, > Justin > > 1. ./src/include/utils/agtype_parser.h > 2. ./src/backend/utils/adt/agtype_parser.c > 3. ./src/include/utils/agtype.h > 4. ./src/backend/utils/adt/agtype.c > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
