+1 - incubating in name - signature and hash fine - DISCLAIMER is fine - LICENSE and NOTICE are fine - No unexpected binary files - All source files have ASF headers
Note, these script should probably have the ASF header - .github/workflows/scripts/install_r_deps.sh .github/workflows/scripts/install_system_deps_for_r_build.sh .github/workflows/scripts/prepare_sparklyr_sedona_test_env.sh On Tue, Nov 23, 2021 at 12:18 AM Jia Yu <ji...@apache.org> wrote: > Thank you, Justin! I will then fix the notice. > > Folks, we need one more binding vote in order to pass. Could you please > help us? > > Thanks, > Jia > > On Mon, Nov 22, 2021 at 11:25 PM Justin Mclean <jus...@classsoftware.com> > wrote: > > > Hi, > > > > Changing my vote to +1 (binding) > > > > > 1. Sorry for the confusion on the download page. I just fixed Sedona's > > > website. Now the download page is at an obvious place: > > > https://sedona.apache.org/download/ < > https://sedona.apache.org/download/ > > > > > > > Thanks for fixing up your download page. Look like al the links are > > correct on that page as well. > > > > > 2. The reason why we put 2015 - 2021 in the NOTICE is because our > project > > > open-sourced in 2015 and joined the incubator in 2020. Do you think I > > > should change it to 2020 - 2021? > > > > Well it wasn’t an ASF project before then and presumably someone else was > > the copyright owner. Normal what happens is the donated code headers are > > changed and the copyright notice in that header relocated to the NOTICE > > file. > > > > > Since your -1 binding vote is mainly about the website and NOTICE > instead > > > of source code, do you think I should restart the voting process with a > > new > > > release candidate RC2? > > > > No there’s no need (so far) for an RC2 or to even to stop this vote > thread. > > > > Kind Regards, > > Justin >
