Thank you guys. I will fix these issues accordingly! On Tue, Nov 23, 2021 at 10:00 AM sebb <seb...@gmail.com> wrote:
> On Tue, 23 Nov 2021 at 07:09, Jia Yu <ji...@apache.org> wrote: > > > > Hi Justin, > > > > 1. Sorry for the confusion on the download page. I just fixed Sedona's > > website. Now the download page is at an obvious place: > > https://sedona.apache.org/download/ > > Looks good. > > However the hash and sig display names are a bit unusual: normally > these are denoted by just 'sha512' or 'asc' rather than 'src.sha512' > and 'src.asc'. > > Personally, I think it would be clearer to drop the 'src.' and 'bin.' > prefix. > > > > > 2. The reason why we put 2015 - 2021 in the NOTICE is because our project > > open-sourced in 2015 and joined the incubator in 2020. Do you think I > > should change it to 2020 - 2021? > > > > Since your -1 binding vote is mainly about the website and NOTICE instead > > of source code, do you think I should restart the voting process with a > new > > release candidate RC2? > > > > Thanks, > > Jia > > > > > > On Sun, Nov 21, 2021 at 4:02 AM Justin Mclean <jus...@classsoftware.com> > > wrote: > > > > > Hi, > > > > > > I’m -1 (binding) on this release as the project website doesn’t have an > > > obvious download page and they have made previous releases. This has > been > > > brought up on this list before and there was no response from the > project. > > > > > > For this release: > > > - incubating in name > > > - signatures and hashes are fine > > > - disclaimer exists > > > - LICENSE and NOTICE look OK but I didn’t do a detailed check > > > - The year in NOTICE looks incorrect as Sedona only started in the > > > incubator in 2020? > > > - ASF files have headers > > > - No unexpected binary files > > > - Can compile from source > > > > > > Kind Regards, > > > Justin > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > > > For additional commands, e-mail: general-h...@incubator.apache.org > > > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org > For additional commands, e-mail: general-h...@incubator.apache.org > >
