lucasbru commented on code in PR #15661: URL: https://github.com/apache/kafka/pull/15661#discussion_r1559094045
########## tests/kafkatest/services/verifiable_consumer.py: ########## @@ -135,6 +135,28 @@ def last_commit(self, tp): else: return None +# This needs to be used for cooperative and consumer protocol +class IncrementalAssignmentConsumerEventHandler(ConsumerEventHandler): Review Comment: Why can we not implement this in the normal ConsumerEventHandler? It seems it's making incorrect assumptions about the consumer rebalance listener (since previously owned partitions are not guaranteed to be reported in onassinged) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org