philipnee commented on code in PR #15661:
URL: https://github.com/apache/kafka/pull/15661#discussion_r1559662337


##########
tests/kafkatest/services/verifiable_consumer.py:
##########
@@ -135,6 +135,28 @@ def last_commit(self, tp):
         else:
             return None
 
+# This needs to be used for cooperative and consumer protocol
+class IncrementalAssignmentConsumerEventHandler(ConsumerEventHandler):

Review Comment:
   I believe the current listener assumes Eager protocol so it is not making 
the incorrect assumptions.  This (incremental handler) would probably work for 
Eager as well but I thought it would be clearer to distinguish the two.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to