lucasbru commented on code in PR #15661:
URL: https://github.com/apache/kafka/pull/15661#discussion_r1559790393
##########
tests/kafkatest/services/verifiable_consumer.py:
##########
@@ -135,6 +135,28 @@ def last_commit(self, tp):
else:
return None
+# This needs to be used for cooperative and consumer protocol
+class IncrementalAssignmentConsumerEventHandler(ConsumerEventHandler):
Review Comment:
Seems to me that it would have been cleaner to have a single implementation
that treats the value that is passed in `onAssigned` correctly (it is always
incremental by contract, just happens to be non-incremental in the eager case),
instead of having two implementations now. But I'll leave it to a follow-up PR
to clean it up, if you agree, and merge this now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
