lianetm commented on code in PR #15698:
URL: https://github.com/apache/kafka/pull/15698#discussion_r1569498394
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/HeartbeatRequestManager.java:
##########
@@ -380,7 +380,7 @@ private void onErrorResponse(final
ConsumerGroupHeartbeatResponse response,
break;
case UNRELEASED_INSTANCE_ID:
- logger.error("GroupHeartbeatRequest failed due to the instance
id {} was not released: {}",
+ logger.error("GroupHeartbeatRequest failed due to unreleased
instance id {}: {}",
Review Comment:
both. The change for the default log is needed: it was not including the
errorMessage, and that makes it hard to know what happened when you get errors
like INVALID_REQUEST (I personally got it and lost time investigating, so fixed
it). The other log changes are just improvements because I was already there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
