lianetm commented on PR #15698: URL: https://github.com/apache/kafka/pull/15698#issuecomment-2062253184
Thanks for the comments @kirktrue, all addressed. Regarding your comment regarding tests [here](https://github.com/apache/kafka/pull/15698#pullrequestreview-2004676007), we have that covered with the existing `testHeartbeatResponseOnErrorHandling`. That one is validating that we get the right `nextHeartbeatMs` time (which considers the timer), for each specific error type. Is that what you were looking for? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org