To clarify, im wondering who reviewed this on RB and gave it a ship
it? A simple test would have shown it to be broken ;-)
Cheers, Tim
PS: thanks Indrajit for your concern :-)
On Feb 24, 1:57 pm, Timothy Perrett <timo...@getintheloop.eu> wrote:
> Yeah I already fixed it locally to work around the issue; thanks for
> pushing. Was going to do it anyway after lunch.
>
> Do you know who reviewed this? I can't find any reference to it....
>
> Sent from my iPhone
>
> On 24 Feb 2010, at 13:51, Indrajit Raychaudhuri <indraj...@gmail.com>
> wrote:
>
>
>
> > Done in master. Wait for Hudson to respin.
> > Committers, sorry for direct commit to master and breaking the rule
> > but Tim's need was urgent.
>
> > Have done quick smoke test locally.
>
> > - Indrajit
>
> > On 24/02/10 6:56 PM, Timothy Perrett wrote:
> >> I can verify that the issue causing this is:
> >> 703a728af05fddda0f8c5e302cce21a9dc065b54
>
> >> Can we please back this change out as this is affecting ALL lift
> >> applications
>
> >> Cheers, Tim
>
> >> On Feb 24, 1:09 pm, Timothy Perrett<timo...@getintheloop.eu> wrote:
> >>> Scratch that, it just does this all the time - irrelevant of the
> >>> mime
> >>> type.
>
> >>> Reproduce this by making a blank lift app and looking at the source.
>
> >>> Cheers, Tim
>
> >>> On Feb 24, 11:14 am, Timothy Perrett<timo...@getintheloop.eu>
> >>> wrote:
>
> >>>> Guys,
>
> >>>> I see DPP made a bunch of commits last night. Something in there
> >>>> has
> >>>> fundamentally broken the markup parser. Yesterday I deploy an
> >>>> application to production and today I go to update a small bit of
> >>>> copy
> >>>> that marketing want changed and i'm finding that my application is
> >>>> broken....
>
> >>>> With LiftRules.useXhtmlMimeType = false in Boot, I see the
> >>>> following:
>
> >>>> <script type="text/javascript">
> >>>> //<![CDATA[
> >>>> jQuery(document).ready(function()
> >>>> {liftAjax.lift_successRegisterGC();});
> >>>> var lift_page ="F1075228527421HHA";
> >>>> // ]]>
> >>>> </script>
>
> >>>> This is obviously problematic and all my javascript in my
> >>>> application
> >>>> is now doing this. Sorry to be grizzly about this, but its totally
> >>>> untenable for me to be building apps that work one day and are
> >>>> broken
> >>>> the next... I tried reverting to 2.0-M2, but that was giving me
> >>>> errors
> >>>> about not being able to boot SessionMaster. If we are changing
> >>>> stuff
> >>>> in the core of Lift, we need a good number of eyes (that is, people
> >>>> who are ACTIVE committers) on the changes in review board otherwise
> >>>> stuff like this happens (certainly, I don't remember getting review
> >>>> requests for any of these changes that are now causing me
> >>>> problems...)
>
> >>>> I have to get this fixed today otherwise im going to be seriously
> >>>> flamed.
>
> >>>> A very unhappy Tim.
>
> > --
> > You received this message because you are subscribed to the Google
> > Groups "Lift" group.
> > To post to this group, send email to lift...@googlegroups.com.
> > To unsubscribe from this group, send email to
> > liftweb+unsubscr...@googlegroups.com
> > .
> > For more options, visit this group
> > athttp://groups.google.com/group/liftweb?hl=en
> > .
--
You received this message because you are subscribed to the Google Groups
"Lift" group.
To post to this group, send email to lift...@googlegroups.com.
To unsubscribe from this group, send email to
liftweb+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/liftweb?hl=en.
