Hi, I was looking at the commit: commit 2fe3bdbd691a5d11626308e7d660440be6c210c8 Author: Peter Eisentraut <pe...@eisentraut.org> Date: Tue Nov 15 15:35:37 2022 +0100
Check return value of pclose() correctly
In src/bin/pg_ctl/pg_ctl.c :
if (fd == NULL || fgets(filename, sizeof(filename), fd) == NULL ||
pclose(fd) != 0)
If the fgets() call doesn't return NULL, the pclose() would be skipped.
Since the original pclose() call was removed, wouldn't this lead to fd
leaking ?
Please see attached patch for my proposal.
Cheers
pg-ctl-close-fd.patch
Description: Binary data
