On Tue, Nov 15, 2022 at 10:43 AM Ted Yu <yuzhih...@gmail.com> wrote: > Hi, > I was looking at the commit: > > commit 2fe3bdbd691a5d11626308e7d660440be6c210c8 > Author: Peter Eisentraut <pe...@eisentraut.org> > Date: Tue Nov 15 15:35:37 2022 +0100 > > Check return value of pclose() correctly > > In src/bin/pg_ctl/pg_ctl.c : > > if (fd == NULL || fgets(filename, sizeof(filename), fd) == NULL || > pclose(fd) != 0) > > If the fgets() call doesn't return NULL, the pclose() would be skipped. > Since the original pclose() call was removed, wouldn't this lead to fd > leaking ? > > Please see attached patch for my proposal. > > Cheers >
There was potential leak of fd in patch v1. Please take a look at patch v2. Thanks
pg-ctl-close-fd-v2.patch
Description: Binary data
