On 3/23/21 10:56 AM, Bruce Momjian wrote:
On Tue, Mar 23, 2021 at 08:51:32AM -0400, Jan Wieck wrote:
On 3/22/21 7:18 PM, Jan Wieck wrote:
> On 3/22/21 5:36 PM, Zhihong Yu wrote:
> > Hi,
> >
> > w.r.t. pg_upgrade_improvements.v2.diff.
> >
> > + blobBatchCount = 0;
> > + blobInXact = false;
> >
> > The count and bool flag are always reset in tandem. It seems
> > variable blobInXact is not needed.
>
> You are right. I will fix that.
New patch v3 attached.
Would it be better to allow pg_upgrade to pass arbitrary arguments to
pg_restore, instead of just these specific ones?
That would mean arbitrary parameters to pg_dump as well as pg_restore.
But yes, that would probably be better in the long run.
Any suggestion as to how that would actually look like? Unfortunately
pg_restore has -[dDoOr] already used, so it doesn't look like there will
be any naturally intelligible short options for that.
Regards, Jan
--
Jan Wieck
Principle Database Engineer
Amazon Web Services
