Jan Wieck <j...@wi3ck.info> writes:
> So the question remains, how do we name this?

>      --pg-dump-options "<string>"
>      --pg-restore-options "<string>"

If you're passing multiple options, that is

        --pg-dump-options "--foo=x --bar=y"

it seems just horribly fragile.  Lose the double quotes and suddenly
--bar is a separate option to pg_upgrade itself, not part of the argument
for the previous option.  That's pretty easy to do when passing things
through shell scripts, too.  So it'd likely be safer to write

        --pg-dump-option=--foo=x --pg-dump-option=--bar=y

which requires pg_upgrade to allow aggregating multiple options,
but you'd probably want it to act that way anyway.

                        regards, tom lane


Reply via email to