On 2014-03-19 01:08:48 [+0100], Andreas Cadhalpun wrote: > Hi Sebastian, Hi Andreas,
> >It is not done yet. It builds however. I need to add back the fix for > >#621206, consider pkgdatadir and I think that was all. > > I added the command to remove the dependency_libs to override_dh_strip, but > I'm wondering, if we could just not include the .la file. Is it still > needed, e.g. for reverse dependencies? > > Some more comments: > > I don't know, what you intend with pkgdatadir. > And why is '.PHONY: override_dh_strip' necessary? https://wiki.debian.org/DebugPackage says so. > Since you rewrote the debian/rules, I think the copyright for 'Sample > debian/rules' could/should be removed. Okay. > I enhanced the rules file a bit: > * Add some comments. > * Introduce the $CONFIG variable containing the configure flags > (improves readability). > * There are three configure options that I didn't find in the > configure script. What do these do? > - --disable-clamuko > - --with-system-tommath > - --without-included-ltdl I should have taken it from the old rules i.e. left that line unchanged. I was going to review them while swiching to dh_configure (or something similar I don't recall right now). > * Change '$(MAKE) check' to dh_auto_test. > * dh_auto_test automatically disables the test when cross-compiling and > handles nocheck, so the extra check is not needed. > * override_dh_auto_clean: run debconf-updatepo > * Split dh_auto_build in arch-dependent (-a) and -independent (-i). > * override_dh_installinit: clamav-freshclam needs --noscripts > * override_dh_installchangelogs: Install the upstream changelog So you install upstream changelog file in every package. Wouldn't one copy be enough? > * override_dh_compress: Don't compress the example configuration file. > * Update the doc-base file, because PDFs get compressed now. > * Create static debian/clean instead of creating it in every build > (because it doesn't get removed by debian/clean). makes sense .) > * Make the bug script executable. I could swear that this happend somehow in the background. > > I think the result is now quite equivalent to the old rules file. boah. That makes my todo list a little smaller. Thanks. > Best regards, > Andreas Sebastian _______________________________________________ Pkg-clamav-devel mailing list Pkg-clamav-devel@lists.alioth.debian.org http://lists.alioth.debian.org/cgi-bin/mailman/listinfo/pkg-clamav-devel