beliefer commented on code in PR #37588:
URL: https://github.com/apache/spark/pull/37588#discussion_r1377425633
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -2483,7 +2477,7 @@ private[sql] object QueryCompilationErrors extends
QueryErrorsBase with Compilat
messageParameters = Map(
"specKeys" -> specKeys,
"partitionColumnNames" -> partitionColumnNames.mkString(", "),
- "tableName" -> tableName))
+ "tableName" -> toSQLId(tableName)))
Review Comment:
I got it now. In fact, you added the test cases into the base class
ShowTablesSuiteBase, so the output is different from v1 and v2.
So we can add this test case into `v1.ShowTablesSuite` and
`v2.ShowTablesSuite` and avoid add `toSQLId`.
After this PR, you can create another PR to fix the error class.
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/errors/QueryCompilationErrors.scala:
##########
@@ -2483,7 +2477,7 @@ private[sql] object QueryCompilationErrors extends
QueryErrorsBase with Compilat
messageParameters = Map(
"specKeys" -> specKeys,
"partitionColumnNames" -> partitionColumnNames.mkString(", "),
- "tableName" -> tableName))
+ "tableName" -> toSQLId(tableName)))
Review Comment:
I got it now. In fact, you added the test cases into the base class
`ShowTablesSuiteBase`, so the output is different from v1 and v2.
So we can add this test case into `v1.ShowTablesSuite` and
`v2.ShowTablesSuite` and avoid add `toSQLId`.
After this PR, you can create another PR to fix the error class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
